Improve performance of ApolloFederatedTracing wrapper
#2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
commented
Mar 18, 2024
| @@ -39,7 +39,7 @@ sealed trait Wrapper[-R] extends GraphQLAspect[Nothing, R] { self => | |||
| that.withWrapper(self) | |||
|
|
|||
| // Disables tracing only for wrappers in the caliban package | |||
| final private[caliban] def trace: Trace = Trace.empty | |||
| final private[caliban] implicit def trace: Trace = Trace.empty | |||
There was a problem hiding this comment.
Just noticed this wasn't an implicit 🤦♂️
| @@ -98,41 +98,50 @@ object ApolloFederatedTracing { | |||
| wrapPureValues: Boolean | |||
| ): FieldWrapper[Any] = | |||
| new FieldWrapper[Any](wrapPureValues) { | |||
|
|
|||
| private def updateState(startTime: Long, fieldInfo: FieldInfo)(result: Either[ExecutionError, ResponseValue]) = | |||
| ZQuery.succeed { | |||
There was a problem hiding this comment.
Do we even need to wrap this? We only execute it within a foldQuery. Could we just execute purely and then lift the result?
There was a problem hiding this comment.
Yeah I think that's better actually. I'll do the change
|
@ghostdogpr @paulpdaniels I made another small optimization that I missed initially. I'll merge it in once CI passes, but let me know if you have any concerns about it |
ghostdogpr
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, we reduce the number of flatmaps performed in the ApolloFederatedTracing wrapper for the happy path (when fields are successes). Since this wrapper wraps pure values by default, this should see a noticeable improvement for users OOTB