-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSocket support for caliban-quick
#2150
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
db862d8
Add websocket support for caliban-quick
kyri-petrou a93aeaf
Fix import error
kyri-petrou f8a5e72
Fix Scala 3 compiling
kyri-petrou 4f9729d
Make zio-http websocket config configurable
kyri-petrou 16fcf2c
Fix content-type of graphiql endpoint
kyri-petrou c007baa
Merge branch 'refs/heads/series/2.x' into quick-websockets
kyri-petrou b006187
PR comment
kyri-petrou 7248793
Merge branch 'refs/heads/series/2.x' into quick-websockets
kyri-petrou 6b481b5
Add method to construct WebSocketHooks from a StreamTransformer
kyri-petrou 7830e26
Use caliban-quick in stitching example
kyri-petrou 5354501
Use port 8080 in stitching example
kyri-petrou be6565c
Fix scaladoc
kyri-petrou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
adapters/quick/src/main/scala/caliban/quick/WebSocketConfig.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package caliban.quick | ||
|
||
import caliban.ws.WebSocketHooks | ||
import zio._ | ||
import zio.http.{ WebSocketConfig => ZWebSocketConfig } | ||
|
||
case class WebSocketConfig[-R]( | ||
keepAliveTime: Option[Duration], | ||
hooks: WebSocketHooks[R, Any], | ||
zHttpConfig: ZWebSocketConfig | ||
) { | ||
def withHooks[R1](newHooks: WebSocketHooks[R1, Any]): WebSocketConfig[R & R1] = | ||
copy(hooks = hooks ++ newHooks) | ||
|
||
def withKeepAliveTime(time: Duration): WebSocketConfig[R] = | ||
copy(keepAliveTime = Some(time)) | ||
|
||
def withZHttpConfig(newConfig: ZWebSocketConfig): WebSocketConfig[R] = | ||
copy(zHttpConfig = newConfig) | ||
} | ||
|
||
object WebSocketConfig { | ||
def default: WebSocketConfig[Any] = WebSocketConfig(None, WebSocketHooks.empty, ZWebSocketConfig.default) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paulpdaniels @frekw, do you happen to know how should the server handle invalid messages? Based on this logic, we are going to raise an error if the frame cannot be decoded to
GraphQLWSInput
, which AFAICT will close the stream.Is this sound? Or should we be ignoring messages we can't decode?