Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Monix Task and Observable #214

Merged
merged 4 commits into from
Feb 17, 2020
Merged

Support for Monix Task and Observable #214

merged 4 commits into from
Feb 17, 2020

Conversation

ghostdogpr
Copy link
Owner

Fixes #212

  • Instances of Schema for Task and Observable
  • Extension methods checkAsync and executeAsync that return a Task
  • Small sample project that shows usage of a Task in a query and an Observable in a subscription
  • Documentation

Copy link
Collaborator

@yoohaemin yoohaemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, looks fine overall but I think you could use the interop-monix module instead of the interop-cats module for the conversions themselves. That would simplify the code further and possibly yield better performance.

vuepress/docs/docs/interop.md Outdated Show resolved Hide resolved
build.sbt Show resolved Hide resolved
Copy link

@jvican jvican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghostdogpr Thanks for looking into this so quickly! The code LGTM 👍 You might want to ask for more feedback in the gitter channel for monix https://gitter.im/monix/monix. FYI I've tried the contents in this PR in a branch and it works there too. Will report back if I experience any issues

@ghostdogpr
Copy link
Owner Author

@jvican good idea, I left a message on their Gitter. Thanks for testing too!

@ghostdogpr
Copy link
Owner Author

I changed the implicit requirement from Schedule to ConcurrentEffect[Task], because there is already one in scope within Monix TaskApp. That way, the line implicit val monixScheduler: Scheduler = scheduler is no longer needed.

@ghostdogpr
Copy link
Owner Author

I’m planning to merge this one tomorrow if there are no further remarks. I’ll release a version right after.

@ghostdogpr ghostdogpr merged commit 535c52d into master Feb 17, 2020
@ghostdogpr ghostdogpr deleted the monix branch February 17, 2020 02:52
@jvican
Copy link

jvican commented Feb 21, 2020

Thank you @ghostdogpr for following up on this and being so quick on resolving this issue! Will upgrade to the new version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Monix subscriptions
3 participants