-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Monix Task and Observable #214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, looks fine overall but I think you could use the interop-monix
module instead of the interop-cats
module for the conversions themselves. That would simplify the code further and possibly yield better performance.
interop/monix/src/main/scala/caliban/interop/monix/MonixInterop.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ghostdogpr Thanks for looking into this so quickly! The code LGTM 👍 You might want to ask for more feedback in the gitter channel for monix https://gitter.im/monix/monix. FYI I've tried the contents in this PR in a branch and it works there too. Will report back if I experience any issues
@jvican good idea, I left a message on their Gitter. Thanks for testing too! |
I changed the implicit requirement from |
I’m planning to merge this one tomorrow if there are no further remarks. I’ll release a version right after. |
Thank you @ghostdogpr for following up on this and being so quick on resolving this issue! Will upgrade to the new version soon. |
Fixes #212
Schema
forTask
andObservable
checkAsync
andexecuteAsync
that return aTask
Task
in a query and anObservable
in a subscription