codegen: Generate the GQLDeprecated annotation #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnspade
force-pushed
the
codegen-annotations
branch
from
bd82e46 to
964defd
Compare
|
Nice! Could you add one case of this to the existing scripted tests (in the sbt plugin module). It will make sure the generated code compiles well. |
johnspade
force-pushed
the
codegen-annotations
branch
from
19569da to
fcc56e4
Compare
Done, added these cases to the scripted tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the schema-first approach, it is useful to add annotations from the schema to the generated Caliban code, they will be used for introspection. It's helpful to see deprecated fields and types in tools like Graphiql.
The changes also include a small improvement following up on my previous PR #2064: root fields should also be generated with the parameterized effect type in the case of nested lazy fields.