Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we focus mostly on improving performance of field wrappers (specifically, of tracing wrappers). These wrappers are executed for each effectfull field (or for all fields), so even the smallest improvement can have an impact on performance.
The main changes are that we use
AtomicReference
in-favour ofRef
(which is what zio's Ref uses under the hood), and the unsafe variant of ZIO's clock. This allows us to skip a few.flatMap
s when wrapping fields as we can "unsafely" get the current nano time and write to the AtomicReference.I also disabled tracing for Wrappers and Schemas that we provide. This doesn't affect performance but it'll make debugging for users easier as they won't be seeing a lot of traces resulting from our code
series 2.x:
PR: