Enable Scala 2 inliner and update dependencies #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Dec 20, 2023
| @@ -104,9 +104,9 @@ private[caliban] trait StringParsers { | |||
| case _ => l1 | |||
| } | |||
| // remove start lines that are only whitespaces | |||
| val l3 = l2.dropWhile("[ \t]*".r.replaceAllIn(_, "").isEmpty) | |||
| val l3 = l2.dropWhile("[ \t]*".r.replaceAllIn(_, "").isEmpty): @noinline | |||
There was a problem hiding this comment.
Can you add a comment explaining why noinline?
There was a problem hiding this comment.
Scala 2.12 (only) inlines the dropWhile method and a compiler error is raised because of it. I'll add that in
ghostdogpr
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subbing in for Scala Steward who seems to be on holidays 🤖🌴 .
Also enabling Scala 2's inliner. I've only enabled inlining from the standard library, but I'm happy to enable it globally if we don't see an issue with it