Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid wrapping of Step[R] into Option in ObjectFieldResolver #2053

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Avoid wrapping of Step[R] into Option in ObjectFieldResolver #2053

merged 2 commits into from
Dec 20, 2023

Conversation

kyri-petrou
Copy link
Collaborator

Micro-optimization for the object field resolution

ghostdogpr
ghostdogpr approved these changes Dec 20, 2023
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You got the rare flaky test issue

@kyri-petrou kyri-petrou merged commit 8f33f07 into series/2.x Dec 20, 2023
10 checks passed
@kyri-petrou kyri-petrou deleted the avoid-option-object-field-resolver branch December 20, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyri-petrou @ghostdogpr