More executor optimizations #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Dec 20, 2023
| @@ -111,7 +112,13 @@ object Executor { | |||
| i += 1 | |||
| remaining = remaining.tail | |||
| } | |||
| reduceList(lb.result(), Types.listOf(currentField.fieldType).fold(false)(_.isNullable)) | |||
| reduceList( | |||
There was a problem hiding this comment.
Is this actually faster? fold is inline.
There was a problem hiding this comment.
Inlining via the @inline annotation only works in Scala 2 and only if it's enabled via the -opt-inline-from: compiler flag (which we don't have enabled - I think we might want to enable that one).
ghostdogpr
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main optimization in this PR is that we avoid an extra flatMap for each field when the field is not nullable.