Implement path
via PathValue
instead of Either[String, Int] for paths
#2048
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of an experiment just to see what we think.
So, what's wrong with
Either[String, Int]
? There are 2 things that are kind of wrong with it:With this PR, we substitute the
Either[String, Int]
withPathValue
, a sealed trait that is extended byStringValue
andIntValue.IntNumber
. In a world where we've all migrated to Scala 3, this could have easily been atype PathValue = StringValue | IntValue.IntNumber
but unfortunately we have to make the code compatible with Scala 2 🥲.I also made a few changes to some of the methods used to parse paths / IntValues from String to avoid wrapping them in
Try
(which causes boxing) and avoid throwing exceptions as a control flow mechanism