Optimize unnecessary .map when handling nullable fields #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
commented
Dec 16, 2023
Comment on lines
+186
to
+189
| q.foldQuery( | ||
| handleError(_).map((name, _)), | ||
| v => ZQuery.succeed((name, v)) | ||
| ) |
There was a problem hiding this comment.
TL;DR this is the main optimization
ghostdogpr
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few micro-optimizations in this PR, but the main one is that we avoid the extra
.mapfor nullable object fields. This results in roughly ~10% in our execution benchmarks, although that's fairly biased as all ZQuery fields are nullable