Allow parallel execution of mutation non-top level fields #2040
Conversation
|
I don't think it makes a difference for subscriptions because we just produce a response value that contains all the streams |
| case QueryExecution.Sequential => ZQuery.foreach(in)(as) | ||
| case QueryExecution.Parallel => ZQuery.foreachPar(in)(as) | ||
| case QueryExecution.Batched => ZQuery.foreachBatched(in)(as) | ||
| executionMode match { |
There was a problem hiding this comment.
Does that really make a difference to use ints? Code would be cleaner without 😄
There was a problem hiding this comment.
Pattern matching on Ints in increments compiles to a tableswitch, which has O(1) performance regardless of the number of elements in the pattern matching. Plus I do think that equality on ints is less complex than on objects since there's no need for type-checking.
Having said that, we only have 3 elements, and this code is probably a millionth of the overall execution complexity so I'll just go back to making it more readable 😅
There was a problem hiding this comment.
Made the change. I placed Sequential last now though since I find it very hard to believe anyone would ever want to use that.. right?
Closes #2035
PS: I didn't find anything in the spec that specifies that subscriptions should be executed sequentially. @ghostdogpr @paulpdaniels do you happen to know how come and the execution mode for subscriptions was forced to
Sequential?