Object query & Scla 3 optimizations #2033
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we optimize the creation of the object query by utilizing indices instead of a Map when an object . This gives us roughly 7-8% improvement in queries that contain a lot of objects with both pure and effectful fields:
Additionally, in Scala 3 we can annotate
lazy val
s with@threadUnsafe
which compiles to a faster implementation which can be used in cases that the initialization is known to be performed by a single thread. It more or less compiles to the following:This is OK for this usecase because we initialise the lazy val's during the call of the
toType
method, which is guaranteed to be performed on a single thread when we create the interpreter.