Delegate registration of FieldMetrics to blocking threadpool #2014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that's been bugging me for some time. We've seen previously that writing the field metrics to the registry can be relatively expensive when it comes to CPU time.
To reduce runtime performance overhead, we've been forking the process. However, the forked fiber still runs on the default executor which has very limited number of threads (sized to the number of available CPU). In environments with low number of CPU, this means that we might be "starving" the default executor threadpool for writing field metrics.
One option (as in this PR) is to run the metrics registering effect on the blocking executor. However, this has the drawback of spawning additional threads in the unbounded blocking threadpool.
Alternatives:
ZIO.blocking
is good enough or if (2) is not an issueThoughts?