Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using zipWithIndex in executor #2013

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Avoid using zipWithIndex in executor #2013

merged 1 commit into from
Nov 18, 2023

Conversation

kyri-petrou
Copy link
Collaborator

The fact that we use .zipWithIndex in the hotpath has been bugging me for a while. I tried one too many combinations on making this more performant, but this seems to give the best outcome without breaking changes

(PS: Introducing (very) breaking changes improves the performance but only marginally

series/2.x

[info] NestedZQueryBenchmark.multifieldBatchedQuery1000       thrpt    5    454.632 ±   30.818   ops/s
[info] NestedZQueryBenchmark.multifieldBatchedQuery10000      thrpt    5    36.282 ±    0.412   ops/s

PR:

[info] NestedZQueryBenchmark.multifieldBatchedQuery1000       thrpt    5   486.285 ±    8.043   ops/s
[info] NestedZQueryBenchmark.multifieldBatchedQuery10000      thrpt    5    42.255 ±    1.161   ops/s

@kyri-petrou kyri-petrou merged commit 3cb5e02 into series/2.x Nov 18, 2023
10 checks passed
@kyri-petrou kyri-petrou deleted the avoid-zip-with-index branch November 18, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyri-petrou @ghostdogpr