ZQuery Improvements #200
Merged
ZQuery Improvements #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Feb 5, 2020
|
All set. |
ghostdogpr
reviewed
Feb 5, 2020
| * and then combining the values to produce a summary, together with the | ||
| * result of execution. | ||
| */ | ||
| final def summarized[R1 <: R, E1 >: E, B, C](f: (B, B) => C)(summary: ZIO[R1, E1, B]): ZQuery[R1, E1, (C, A)] = |
There was a problem hiding this comment.
Shall we switch the parameters here too?
There was a problem hiding this comment.
Yes. I was slightly inclined to wait until RC18 and make conforming changes to that so we track the public ZIO API for identical methods but happy to change now as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to ZQuery based on recent suggestions:
summarizedandtimedmethods on ZQuery analogous to existing methods on ZIO. These do not interfere with query batching.fromRequestOptionconstructor on ZQuery to construct queries that returnNoneinstead of failing with aQueryFailureif a data source does not return a result for a request. ImplementsfromFunctionOption,fromFunctionOptionM,fromFunctionBatchedOption, andfromFunctionBatchedOptionMto create data sources that may not return a result for a request.fromFunctionBatchedWithMnow also allows you to use an effect that can fail. If the effect fails the failure will be returned for all requests.