Attempt at fixing Sum type schema derivation for good #1994
Conversation
|
My schema is equivalent between Scala 2 and 3 now, cheers! Some of the unions aren't ordered alphabetically any more though. |
|
Hey @guymers happy to hear it's all working as expected (well, for the most of it). We just released a new version with all the fixes + some major performance improvements. As for the ordering, if you can provide a repro and open an issue I can look into it. And thanks again for reporting the issues, finally managed to get to the source of it and make the Scala 2 & 3 derivation equivalent (famous last words 😄 ) |
|
Hey @guymers, we've just discovered a regression that was introduced with these changes. Working on a fix now and we'll release a new version once I have the fix in, but in the meantime don't use version 2.4.2. |
|
Only for Scala 3 yeah? I haven't merged cross version Scala 3 support yet for our GraphQL module and we wont move our app from 2.13 to 3 until after the holidays. |
|
Yes only for Scala 3 👍 Should be fixed by #2005 |
Fixes #1992
Fixes #1993
... and hopefully all issues with nested sum types 🥲