Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a warning about impure expression #1965

Merged

Conversation

satorg
Copy link
Contributor

@satorg satorg commented Oct 29, 2023

See details in Discord

Under some circumstances the build can start failing with the following error:

[error] .../ghostdogpr/caliban/codegen-sbt/src/main/scala/caliban/codegen/CompileTimeCalibanPlugin.scala:269:57: a pure expression does nothing in statement position; multiline expressions might require enclosing parentheses
[error]                           ensureCompiled(serverProject).value
[error]                                                         ^
[error] No warnings can be incurred under -Xfatal-warnings.
[error] two errors found
[error] (codegenSbt / Compile / compileIncremental) Compilation failed

Usually it does not happen, however can show up if one uses Metals to work with the project (e.g. vscode).

@ghostdogpr ghostdogpr merged commit 2a5c83b into ghostdogpr:series/2.x Oct 29, 2023
@ghostdogpr
Copy link
Owner

Thanks!

@satorg satorg deleted the fix-warning-about-impure-expr branch October 30, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants