-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP GET support for Akka and http4s #177
Conversation
use AkkaHttp DSL combinator ~ simplified a bit
Introduced some informal suggestions in latest commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few remarks to make the code shorter. Also the CI failed on 2.13, any idea why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few remarks to make the code shorter. Also the CI failed on 2.13, any idea why?
You quoted Ross Baker on chat as scalac 2.13 bug: scala/bug#11457 (comment)
There is this as workaround? https://github.com/ghik/silencer
Pertains to #175