Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(error): Correctly encode the error message. #145

Merged
merged 1 commit into from
Jan 3, 2020
Merged

fix(error): Correctly encode the error message. #145

merged 1 commit into from
Jan 3, 2020

Conversation

paulpdaniels
Copy link
Collaborator

This makes errors rendered by the Circe encoder more spec compliant. Note there are still some pieces missing from the error handling but which require a larger footprint to change.

@paulpdaniels paulpdaniels mentioned this pull request Jan 3, 2020
Closed
ghostdogpr
ghostdogpr approved these changes Jan 3, 2020
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ghostdogpr ghostdogpr merged commit e71fc6c into ghostdogpr:master Jan 3, 2020
@ghostdogpr ghostdogpr mentioned this pull request Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulpdaniels @ghostdogpr