Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map java.util.UUID to ID instead of String #126

Merged
merged 3 commits into from
Dec 17, 2019

Conversation

mriceron
Copy link
Contributor

The scope of the PR is to map java.util.UUID to ID instead of String.

I'm not sure which is the best place to add a test for this since I just took a quick look at the project, I'm open to suggestions.

@ghostdogpr
Copy link
Owner

Awesome!

There was a test in ExecutionSpec and it still passes since the result is the same as before. If you want to check the returned type explicitly, you could add one here: https://github.com/ghostdogpr/caliban/blob/master/core/src/test/scala/caliban/schema/SchemaSpec.scala

@mriceron mriceron requested a review from ghostdogpr December 16, 2019 14:33
@ghostdogpr
Copy link
Owner

Thanks! I’ll merge it tomorrow before releasing a new version.

@mriceron
Copy link
Contributor Author

Thanks to you for the library and the support! Looking forward to the release :D

@ghostdogpr ghostdogpr merged commit dad81ed into ghostdogpr:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants