Fix fields merging and improve performance #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
commented
Dec 11, 2021
| field.fields.foreach { field => | ||
| if (field.condition.forall(_.contains(typeName))) { | ||
| val name = field.alias.getOrElse(field.name) | ||
| map.get(name) match { |
There was a problem hiding this comment.
map was never updated 🤦♂️
ghostdogpr
commented
Dec 11, 2021
| @@ -871,6 +870,9 @@ object ExecutionSpec extends DefaultRunnableSpec { | |||
| | ... on Human { | |||
| | height | |||
| | } | |||
| | ... on Human { | |||
There was a problem hiding this comment.
Added this intentionally to make sure the result has the field only once.
frekw
approved these changes
Dec 11, 2021
| @@ -35,7 +36,33 @@ object Field { | |||
| rootType: RootType | |||
| ): Field = { | |||
| def loop(selectionSet: List[Selection], fieldType: __Type): Field = { | |||
| val fieldList = List.newBuilder[Field] | |||
| val fieldList = ArrayBuffer.empty[Field] | |||
There was a problem hiding this comment.
Should we give this a size hint as well? I'd expect that to provide a minor improvement in 99% of cases where people don't duplicate their fields (and really only penalizes us in the pathological case).
There was a problem hiding this comment.
But we don't know the size without going through fragments recursively.
paulpdaniels
approved these changes
Dec 11, 2021
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 24, 2022
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields were not properly merged during execution. I moved the merging to the validation phase and added some performance optimizations.
Before:
After: