Respect variables with no value provided #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resolving a value for a variable, if a value has not been provided and it has no default then do not include it instead of setting it to `null`.
frekw
reviewed
Dec 9, 2021
frekw
reviewed
Dec 9, 2021
| case value: Value => value | ||
| for { | ||
| definition <- variableDefinitions.find(_.name == name) | ||
| value <- variableValues.get(name).orElse(definition.defaultValue) |
There was a problem hiding this comment.
definition.defaultValue is an Option so getOrElse is not applicable?
There was a problem hiding this comment.
But so is variableValues.get(name) since you're getting it from a map, right?
There was a problem hiding this comment.
@frekw getOrElse expects an A, but defaultValue is an Option[A]. It's orElse, not getOrElse.
There was a problem hiding this comment.
I meant getOrElse from Map :) https://scastie.scala-lang.org/jywLcoZARNG8KOrI7LDHqw
There was a problem hiding this comment.
But in either case, doesn't matter much.
There was a problem hiding this comment.
No, b is of type Any if you do that :P
|
Thanks! |
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 24, 2022
When resolving a value for a variable, if a value has not been provided and it has no default then do not include it instead of setting it to `null`.
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 27, 2022
When resolving a value for a variable, if a value has not been provided and it has no default then do not include it instead of setting it to `null`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving a value for a variable, if a value has not been provided
and it has no default then do not include it instead of setting it to
null.