Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update scalafmt #1174

Merged
merged 1 commit into from
Nov 25, 2021
Merged

chore: update scalafmt #1174

merged 1 commit into from
Nov 25, 2021

Conversation

AlixBa
Copy link
Contributor

@AlixBa AlixBa commented Nov 25, 2021 •
edited
Loading

When trying to update to sbt-scalafmt to 2.4.4 on projects using Caliban, we get an error on codegen/formatting because one method is deprecated

Generating code for schema.graphql
org.scalafmt.dynamic.ScalafmtDynamicError$ScalafmtInterfaceMethodDeprecated: Method Scalafmt.withRespectVersion is deprecated
org.scalafmt.dynamic.ScalafmtDynamic.withRespectVersion(ScalafmtDynamic.scala:62)
org.scalafmt.dynamic.ScalafmtDynamic.withRespectVersion(ScalafmtDynamic.scala:20)
caliban.tools.Formatter$.$anonfun$format$2(Formatter.scala:27)
zio.internal.FiberContext.evaluateNow(FiberContext.scala:490)
zio.internal.FiberContext.$anonfun$evaluateLater$1(FiberContext.scala:776)
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
java.base/java.lang.Thread.run(Thread.java:832)

@AlixBa AlixBa force-pushed the update-scalafmt branch 2 times, most recently from 0605a71 to a5b079e Compare November 25, 2021 09:58
@AlixBa
Copy link
Contributor Author

AlixBa commented Nov 25, 2021

@ghostdogpr all good

ghostdogpr
ghostdogpr approved these changes Nov 25, 2021
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghostdogpr ghostdogpr merged commit 509ea49 into ghostdogpr:master Nov 25, 2021
Fluxx pushed a commit to Fluxx/caliban that referenced this pull request Jan 24, 2022
@AlixBa @Fluxx
chore: update scalafmt (ghostdogpr#1174)
9331a8a
Fluxx pushed a commit to Fluxx/caliban that referenced this pull request Jan 27, 2022
@AlixBa @Fluxx
chore: update scalafmt (ghostdogpr#1174)
e7ad144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guizmaii guizmaii guizmaii left review comments

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlixBa @guizmaii @ghostdogpr