Custom Scalar Specification URLs #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| implicit val bigIntSchema: Schema[Any, BigInt] = scalarSchema("BigInt", None, None, IntValue(_)) | ||
| implicit val doubleSchema: Schema[Any, Double] = scalarSchema("Float", None, None, FloatValue(_)) | ||
| implicit val floatSchema: Schema[Any, Float] = scalarSchema("Float", None, None, FloatValue(_)) | ||
| implicit val bigDecimalSchema: Schema[Any, BigDecimal] = scalarSchema("BigDecimal", None, None, FloatValue(_)) |
There was a problem hiding this comment.
I wonder if we can go ahead and provide urls for any of these. UUID for instance does have a specification I believe.
There was a problem hiding this comment.
You mean the official UUID spec, or something specific to GraphQL?
There was a problem hiding this comment.
Ah, the spec links to https://tools.ietf.org/html/rfc4122
There was a problem hiding this comment.
But we use ID for that, which is a standard scalar, and they say that standard scalars shouldn't have that URL.
There was a problem hiding this comment.
But maybe the types in TemporalSchema could link to the relevant RFCs?
paulpdaniels
approved these changes
Nov 25, 2021
frekw
reviewed
Nov 25, 2021
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 24, 2022
* Custom Scalar Specification URLs * Use fold
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 27, 2022
* Custom Scalar Specification URLs * Use fold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1159