Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deprecated directive on handrolled fields #1168

Merged
merged 4 commits into from
Nov 24, 2021
Merged

fix: Deprecated directive on handrolled fields #1168

merged 4 commits into from
Nov 24, 2021

Conversation

frekw
Copy link
Collaborator

@frekw frekw commented Nov 23, 2021

No description provided.

@frekw frekw requested a review from ghostdogpr November 23, 2021 23:47
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghostdogpr ghostdogpr merged commit c13b3d9 into ghostdogpr:master Nov 24, 2021
@frekw frekw deleted the fix/directives-on-handrolled-fields branch November 24, 2021 17:49
Fluxx pushed a commit to Fluxx/caliban that referenced this pull request Jan 24, 2022
* wip support deprecated on hand rolled schemas

* fix test

* set deprecated for fieldWithArgs as well

* Extract helpers
Fluxx pushed a commit to Fluxx/caliban that referenced this pull request Jan 27, 2022
* wip support deprecated on hand rolled schemas

* fix test

* set deprecated for fieldWithArgs as well

* Extract helpers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants