Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested uploads #1167

Merged
merged 5 commits into from
Nov 24, 2021
Merged

fix: nested uploads #1167

merged 5 commits into from
Nov 24, 2021

Conversation

frekw
Copy link
Collaborator

@frekw frekw commented Nov 23, 2021

No description provided.

@frekw frekw marked this pull request as ready for review November 23, 2021 22:41
@frekw frekw requested a review from ghostdogpr November 23, 2021 22:42
@frekw frekw changed the title wip: nested uploads fix: nested uploads Nov 23, 2021
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like the old logic was quite wrong.

@ghostdogpr ghostdogpr merged commit b4a3d36 into ghostdogpr:master Nov 24, 2021
@frekw frekw deleted the fix/nested-uploads branch November 24, 2021 17:49
Fluxx pushed a commit to Fluxx/caliban that referenced this pull request Jan 24, 2022
* wip upload fix

* fix lists

* make sure we update variables in place

* fix assertion

* remove println
Fluxx pushed a commit to Fluxx/caliban that referenced this pull request Jan 27, 2022
* wip upload fix

* fix lists

* make sure we update variables in place

* fix assertion

* remove println
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants