Support multiple setting sets per file #1156
Conversation
kubukoz
force-pushed
the
multiple-outputs-per-file
branch
from
ebf6845 to
e5a6f46
Compare
| calibanSetting(file("src/main/graphql/schema.graphql"))( // Explicitly constrain to disambiguate | ||
| cs => | ||
| cs.clientName("Client") | ||
| calibanSetting(file("src/main/graphql/schema.graphql"))( // Explicitly constrain to disambiguate |
There was a problem hiding this comment.
tbh I don't get what this "constrains", is that comment up to date?
There was a problem hiding this comment.
Certainly not the most helpful comment, as I don't understand what needed to be disambiguated here -- perhaps back when it was possible (or intended) to star-glob multiple files? I could see trying to disambiguate between the few .graphql test specifications we had at that time.
|
@ghostdogpr updated with a test and some other changes (see note in PR description) :) cc @guizmaii I'd appreciate some eyes on this |
| calibanSetting(file("src/main/graphql/schema.graphql"))( // Explicitly constrain to disambiguate | ||
| cs => | ||
| cs.clientName("Client") | ||
| calibanSetting(file("src/main/graphql/schema.graphql"))( // Explicitly constrain to disambiguate |
There was a problem hiding this comment.
Certainly not the most helpful comment, as I don't understand what needed to be disambiguated here -- perhaps back when it was possible (or intended) to star-glob multiple files? I could see trying to disambiguate between the few .graphql test specifications we had at that time.
| ) | ||
| val matchingSettingSets = fileSettings.collect { | ||
| case needle if source.toPath.endsWith(needle.file.toPath) => needle.settings | ||
| }.map(defaults.combine(_)) |
There was a problem hiding this comment.
This is the intended change in this PR, from what I can tell. I was foldLeft-ing in the beginning to permit tiered configuration, but that was before the cs pattern was discovered. I don't think it's useful to accumulate anymore, if the previous implementation was desired, it is possible to define a generic CalibanSettings => CalibanSettings and apply that before you chain the rest of your config.
vuepress/docs/docs/client.md
Outdated
| Compile / caliban / calibanSources := file("caliban") | ||
| ``` | ||
|
|
||
| If you want to only include certain files in a directory, you can override that as well with an explicit `caliban / sources` entry: |
There was a problem hiding this comment.
This isn't actually true, since calibanSources is a File, not a List[File] -- the comment doesn't scale and will trip up users
There was a problem hiding this comment.
Updated, hopefully it's correct now
|
LGTM, I will merge! |
This would be useful in situations where you want to generate both a server and a client from a single schema file, with potentially different settings.
Update: Added some more changes:
calibanGenClientcalls and one for the setting-based generation