Coerce int values into float when expected #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frekw
reviewed
Nov 17, 2021
| variables = Some( | ||
| Map( | ||
| "input" -> InputValue.ObjectValue( | ||
| Map("float" -> Value.IntValue(42)) |
There was a problem hiding this comment.
Hm, this strikes me as a bit odd since JSON only supports floats 🤔 I would probably have expected the coercion to be the other way around...
But perhaps we have some smartness in the parser to parse numbers without decimals as ints so we need to deal with both cases?
There was a problem hiding this comment.
The parser would parse into a FloatValue only if there is a dot or a e for exponent.
There was a problem hiding this comment.
In scala 2. The scala 3 one checks for int before float so the result is the same.
There was a problem hiding this comment.
According to the spec, float should not be coerced into int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also did a bit of unrelated cleanup.