feat: Add @GQLExcluded #1141
Merged
feat: Add @GQLExcluded #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Nov 15, 2021
| @@ -64,6 +64,7 @@ trait SchemaDerivation[R] extends LowPriorityDerivedSchema { | |||
| Some(getName(ctx)), | |||
| getDescription(ctx), | |||
| ctx.parameters | |||
| .filter(p => !p.annotations.exists(_ == GQLExcluded())) | |||
There was a problem hiding this comment.
How about .filterNot(_.annotations.exists(_ == GQLExcluded()))?
There was a problem hiding this comment.
👍 didn't know that existed!
There was a problem hiding this comment.
Haha sure! I sometimes try to shy away from multiple levels of _ but I think it's fine in this case!
ghostdogpr
approved these changes
Nov 15, 2021
|
Can you also add it here: https://github.com/ghostdogpr/caliban/blob/master/vuepress/docs/docs/schema.md#annotations But a separate PR would be great, so that I can merge the doc PR after the next release. That way it doesn't appear on the website before it's released (docs are updated right after they're merged to master). |
|
Absolutely, here's a separate PR: #1142 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1040.
Didn't add support to exclude an enum member since it felt like it'd need special handling (what are we supposed to output as result if we were to get back a value that's
GQLExcluded?).