Generator improvements #1137
Merged
Generator improvements #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nikodemin
commented
Nov 11, 2021
nikodemin
commented
- refactor generators code and tests
- make possible to generate graphQL interface in schema generator
- delete redundant implicits package
- add GenType argument for plugin to make convenient schema generation
* improve generator
* refactor generators code and test * delete redundant implicits package
* refactor generators code and test * delete redundant implicits package
* refactor generators code and test * delete redundant implicits package
* refactor generators code and test * delete redundant implicits package
* fix test
# Conflicts: # tools/src/main/scala/caliban/tools/ClientWriter.scala
* fix formatting
* fix formatting
* fix formatting
|
@ghostdogpr Hi! I made several improvements in schema generator. Could you please check this pr, when you will have some free time? |
|
Thanks! It's a little bit hard to review because things moved around and the github diff shows as if everything changed. I'll need to spend more time to check it out. I just merged a change of the list of reserved keywords, can you rebase and include it into your PR? |
ghostdogpr
approved these changes
Nov 17, 2021
# Conflicts: # tools/src/main/scala/caliban/tools/ClientWriter.scala
* merge master branch
* merge master branch
|
@ghostdogpr Hi! Thank you for review, I merged changes from master branch |
|
If only I'd seen this a week ago, I would've saved so much time 😂 Thanks a lot @nikodemin 🙏 I really needed a way to generate server schemas. |
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 24, 2022
* add interface generation * improve generator * add interface generation * refactor generators code and test * delete redundant implicits package * add interface generation * refactor generators code and test * delete redundant implicits package * add interface generation * refactor generators code and test * delete redundant implicits package * add interface generation * refactor generators code and test * delete redundant implicits package * add interface generation * fix test * add interface generation * fix formatting * add interface generation * fix formatting * add interface generation * fix formatting * add interface generation * merge master branch * add interface generation * merge master branch
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 27, 2022
* add interface generation * improve generator * add interface generation * refactor generators code and test * delete redundant implicits package * add interface generation * refactor generators code and test * delete redundant implicits package * add interface generation * refactor generators code and test * delete redundant implicits package * add interface generation * refactor generators code and test * delete redundant implicits package * add interface generation * fix test * add interface generation * fix formatting * add interface generation * fix formatting * add interface generation * fix formatting * add interface generation * merge master branch * add interface generation * merge master branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.