fix: GQL syntax strings are incorrectly validated as enums #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
approved these changes
Nov 10, 2021
| @@ -6,6 +6,7 @@ import caliban.Value.EnumValue | |||
| import zio._ | |||
| import zio.test._ | |||
| import zio.test.environment.TestEnvironment | |||
| import Assertion._ | |||
There was a problem hiding this comment.
minor: I usually use full paths, so zio.test.Assertion._
| @@ -155,6 +156,27 @@ object FieldArgsSpec extends DefaultRunnableSpec { | |||
| ) | |||
| ) | |||
| ) | |||
| }, | |||
| testM("it doesn't allow strings as enums in GQL syntax") { | |||
There was a problem hiding this comment.
indeed GraphQL string literals must not be accepted as an enum input and instead raise a query error. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bad consequence as a result of #1064
Instead of doing it during validation, we now rewrite the variables to be enums (if they should be) before running the validation, which I think is a more correct approach to it.