Adding aspects and annotations #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is nice! |
paulpdaniels
force-pushed
the
add-aspects-2
branch
from
a793fda to
a3daad6
Compare
paulpdaniels
force-pushed
the
add-aspects-2
branch
from
a3daad6 to
6a6d8d2
Compare
ghostdogpr
approved these changes
Nov 6, 2021
| @@ -9,6 +9,7 @@ import caliban.wrappers.Wrapper.CombinedWrapper | |||
| import caliban.{ CalibanError, GraphQLRequest, GraphQLResponse, ResponseValue } | |||
| import zio.{ UIO, ZIO } | |||
| import zio.query.ZQuery | |||
| import caliban.{ GraphQL, GraphQLAspect } | |||
| * A symbolic alias for `withWrapper`. | ||
| */ | ||
| final def @@[R2 <: R](wrapper: Wrapper[R2]): GraphQL[R2] = withWrapper(wrapper) | ||
| final def @@[LowerR <: UpperR, UpperR <: R](aspect: GraphQLAspect[LowerR, UpperR]): GraphQL[UpperR] = |
There was a problem hiding this comment.
Can you add some scaladoc here and in GraphQLAspect?
paulpdaniels
force-pushed
the
add-aspects-2
branch
from
36b408b to
c350a4c
Compare
ghostdogpr
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies the
Wrappercapabilities into a higher-level abstraction ofGraphQLAspectthe idea being that many of the existing specification capabilities require changes not just to the execution of the request but also to the underlying schema (adding directives, manipulating the underlying graphql).As a demonstration I refactored the
federatefunction into a wrapper (though still kept the existing function for backward compatibility).