-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Tapir to implement adapters #1125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.sbt
# Conflicts: # adapters/zio-http/src/main/scala/caliban/ZHttpAdapter.scala
paulpdaniels
reviewed
Nov 5, 2021
interop/tapir/src/main/scala/caliban/interop/tapir/TapirAdapter.scala
Outdated
Show resolved
Hide resolved
paulpdaniels
reviewed
Nov 5, 2021
paulpdaniels
reviewed
Nov 5, 2021
ghostdogpr
changed the title
[POC] Use Tapir to implement adapters
Use Tapir to implement adapters
Nov 9, 2021
# Conflicts: # examples/src/main/scala/example/federation/FederatedApi.scala # vuepress/docs/docs/README.md
Pushed the play adapter fully migrated. Remaining issues:
|
I think I fixed the flakiness 🤞 |
easel
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will try out the play integrations shortly.
# Conflicts: # vuepress/docs/docs/README.md
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 24, 2022
* Upgrade Scala 3 to 3.1.0 * Give federation a little help * Simplify * Remove weird trick * Update CI * Fix name * Simplify * Simplify * fmt * Simplify * Cleanup * Cleanup * POC * Cleanup * Fix error encoder * Added serializers and tests for GraphQLWSInput and GraphQLWSOutput * Fix mistake * Fix scala 3 * Implement RequestInterceptor support * Remove need for import * Cleanup * Remove Finch adapter * Upload support * Remove no longer needed test * Fix build error * Use fake Schemas * Add makeHttpUploadService to zio http adapter * Remove makeHttpUploadService from zio-http as multipart is not supported in tapir for this interpreter * Cleanup * Move code around and format examples * Reuse TapirAdapter in ZHttpAdapter websocket code * Fix bug * Add test suite for adapters * Fix Scala 3 error * Fix Scala 3 error * Fix Scala 3 error * Use real clock * Use real clock for akka too * Upgrade tapir * Make test more reliable * Migrate play adapter * Debug flakiness * More debugging * Fix flakiness * Remove debug logs * Upgrade Tapir * Fix README
Fluxx
pushed a commit
to Fluxx/caliban
that referenced
this pull request
Jan 27, 2022
* Upgrade Scala 3 to 3.1.0 * Give federation a little help * Simplify * Remove weird trick * Update CI * Fix name * Simplify * Simplify * fmt * Simplify * Cleanup * Cleanup * POC * Cleanup * Fix error encoder * Added serializers and tests for GraphQLWSInput and GraphQLWSOutput * Fix mistake * Fix scala 3 * Implement RequestInterceptor support * Remove need for import * Cleanup * Remove Finch adapter * Upload support * Remove no longer needed test * Fix build error * Use fake Schemas * Add makeHttpUploadService to zio http adapter * Remove makeHttpUploadService from zio-http as multipart is not supported in tapir for this interpreter * Cleanup * Move code around and format examples * Reuse TapirAdapter in ZHttpAdapter websocket code * Fix bug * Add test suite for adapters * Fix Scala 3 error * Fix Scala 3 error * Fix Scala 3 error * Use real clock * Use real clock for akka too * Upgrade tapir * Make test more reliable * Migrate play adapter * Debug flakiness * More debugging * Fix flakiness * Remove debug logs * Upgrade Tapir * Fix README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1117
Closes #841
migration of zio-http ws adapter (currently not supported by tapir)<-- will keep existing code for now