Fix package name extraction in code generation #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! That change makes one of the scripted tests fail, can you check it? ( |
pavlosgi
force-pushed
the
feature/fix-package-name-codegen
branch
from
2617984 to
65c6e21
Compare
pavlosgi
commented
Oct 29, 2021
|
It looks good! Do you mind adding a few unit tests to capture the different cases? Ideally with the 2 lines moved to a function. |
pavlosgi
force-pushed
the
feature/fix-package-name-codegen
branch
2 times, most recently
from
55a8e95 to
6f94102
Compare
|
Done |
ghostdogpr
reviewed
Oct 30, 2021
| test("Package name is empty or default if path doesn't follow correct format") { | ||
| assert(packageAndObject("a/b/c", None, None))( | ||
| equalTo(None -> "Client") | ||
| ) |
There was a problem hiding this comment.
You need to join the assert with &&, otherwise only the last one will be executed (it's assert from zio-test, not the regular scala assert, it's a pure function that returns a test result).
pavlosgi
force-pushed
the
feature/fix-package-name-codegen
branch
from
6f94102 to
b6bc7d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old regex doesn't work properly on paths such as "src/main/scala/company/service/infra/graphql/model.scala". This returns "infra/graphql" as the package name. This is because of [] square brackets to match on one of scala, play or app. I replaced that with a non capturing regex group and that works as expected returning "company/service/infra/graphql" as the package name