Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove blaze dependency from http4s module #1110

Merged
merged 4 commits into from
Oct 22, 2021
Merged

Remove blaze dependency from http4s module #1110

merged 4 commits into from
Oct 22, 2021

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Oct 22, 2021

No description provided.

@ghostdogpr
Copy link
Owner

Good point! Oddly the CI is not triggered, can you try login to https://app.circleci.com/ ?

@kubukoz
Copy link
Contributor Author

kubukoz commented Oct 22, 2021 •
edited
Loading

Done, I'll push an empty commit and hope it runs something...

Update: looks like that did it.

@ghostdogpr
Copy link
Owner

Yep, it worked!

@ghostdogpr
Copy link
Owner

Looks like Blaze is still needed in the tests.

@kubukoz
Copy link
Contributor Author

kubukoz commented Oct 22, 2021

got it, bringing it back for tests only :D

ghostdogpr
ghostdogpr approved these changes Oct 22, 2021
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@ghostdogpr ghostdogpr merged commit 252c385 into ghostdogpr:master Oct 22, 2021
@kubukoz kubukoz deleted the blaze-dep branch October 22, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubukoz @ghostdogpr