[Issue 645] Added Option to exclude deprecation flags. Schema -> Clie… #1082
Conversation
| )(implicit scalarMappings: ScalarMappings): List[(String, String)] = { | ||
| require(packageName.isDefined || !splitFiles, "splitFiles option requires a package name") | ||
|
|
||
| val schemaDef = schema.schemaDefinition | ||
|
|
||
| implicit val excludeDeprecation: Boolean = excludeClientDeprecation |
There was a problem hiding this comment.
This is weird. Why do you need to do that?
There was a problem hiding this comment.
That was one approach. Another is to just pass a parameter, I had to modify quite a few signatures instead, thought better was to do via implicit instead.
|
@harshadbhatia Can you update the plugins documentation too, please? |
Yes, just wanted to make sure it is correctly implemented before updating docs. Will add that now |
|
Ah did you see my comment on Discord? Basically I was saying the deprecated attribute also exists on enum values, would be good to support it too 👍 |
|
Yes I did, just haven't got around to it. Busy day at work. Will try and
look at it tomorrow
…On Tue, 12 Oct 2021, 9:23 pm Pierre Ricadat, ***@***.***> wrote:
Ah did you see my comment on Discord? Basically I was saying the
deprecated attribute also exists on enum values, would be good to support
it too 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1082 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7VFOHQ7ZZKDINZASISPIDUGQED5ANCNFSM5FZEZI3Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Closing old PRs, but feel free to reopen it targeting the |
Closes #645