Add missing final in generated case classes
#1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tests Fix tests Add missing `final` Fix tests Clean
guizmaii
force-pushed
the
add_missing_final_in_generated_code
branch
from
0085251 to
8cbe352
Compare
ghostdogpr
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: https://github.com/guizmaii/poc_compile_time_caliban_client_generation/pull/23/checks?check_run_id=3857963687
After: https://github.com/guizmaii/poc_compile_time_caliban_client_generation/pull/24/checks?check_run_id=3858016758
(The scalafix rule checking that all the case classes are final fail in the "before" run and pass in the "after" run)