feat: Support @GQLDefault #1043
Conversation
There was a problem hiding this comment.
Imports management is THE reason I can't use Metals 😆
Can you add documentation in https://github.com/ghostdogpr/caliban/blob/master/vuepress/docs/docs/schema.md#annotations ?
Looks great otherwise!
| import caliban.Value.FloatValue.FloatNumber | ||
| import caliban.InputValue.ObjectValue | ||
|
|
||
| object DefaultValue { |
There was a problem hiding this comment.
DefaultValueValidator? To keep the naming consistent
There was a problem hiding this comment.
Naming is my weakness :D
| IO.fromEither(Parser.parseInputValue(v)) | ||
| .mapError(e => | ||
| ValidationError( | ||
| s"$errorContext failed to parse default value: ${e.msg}", |
There was a problem hiding this comment.
Is there always a line break at the end of the error?
There was a problem hiding this comment.
Hm, no I don't think so, but there are two messages, msg and explanatoryText.
|
Added docs in 37dd3a1. 👍
I've learnt to live with it. It being automatic is just too big of a convenience 😅. But it seems as if it hadn't run correctly on all files, so I've cleaned the imports up.
|
Hi!
This hopefully closes #1010.
As discussed, I've had some trouble with validating the default values. I think this approach is sort of OK, but am happy to try other paths that might lead to less code duplication.
The error messages aren't great right now because they're lacking some context. Will improve them before marking this PR as ready to go!