Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Akka HTTP Adapter #72

Closed
ghostdogpr opened this issue Nov 8, 2019 · 4 comments · Fixed by #219
Closed

Akka HTTP Adapter #72

ghostdogpr opened this issue Nov 8, 2019 · 4 comments · Fixed by #219
Labels
enhancement New feature or request good first issue Good for newcomers interop Interoperability with other libraries

Comments

@ghostdogpr
Copy link
Owner

ghostdogpr commented Nov 8, 2019 •
edited
Loading

Add a new module similar to caliban-http4s named caliban-akka-http that exposes a REST and a WebSocket API for a given GraphQL interpreter.

If there is common code between the http4s and the akka one, it should be factored out.

I haven't used Akka in a while, so external contributors are welcome to pick this one up!

EDIT: HTTP is done, only WebSocket is missing
@ghostdogpr ghostdogpr added enhancement New feature or request help wanted good first issue Good for newcomers labels Nov 8, 2019
@jona7o
Copy link
Contributor

jona7o commented Dec 4, 2019

I am currently work on a solution with an example.
I haven't use ZIO in a production project, so i hope i'll use the best practises in my PR later this day.
If not, please give me some tipps.

@ghostdogpr
Copy link
Owner Author

@jona7o that would be awesome!

@jona7o jona7o mentioned this issue Dec 4, 2019
Merged
@jona7o
Copy link
Contributor

jona7o commented Dec 4, 2019

I have finished the rest part and started with the ws part.
This week my time is running out so i created a merge request. Perhaps someone else will finish the ws part until i have time for more contribution.

ghostdogpr pushed a commit that referenced this issue Dec 20, 2019
@jona7o @ghostdogpr
#72 akka http without WS (#109)
c007126 
* Add akka-http adapter

* Add akka-http rest sample

* Remove ws related stuff

* Cleanup akkahttp dependencies

* Move http4s Example

* Reuse example data from package

* Update CI and compile new akkahttp module

* Make function private

* Rename

* Fix Example Apps
@phderome
Copy link
Contributor

I'd like to volunteer to pursue this for approximately the period of 1/2 of February.

@ghostdogpr ghostdogpr added interop Interoperability with other libraries and removed help wanted labels Feb 12, 2020
@ghostdogpr ghostdogpr mentioned this issue Feb 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers interop Interoperability with other libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for WebSockets in Akka HTTP Adapter ghostdogpr/caliban
3 participants
@ghostdogpr @jona7o @phderome