Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caliban client: better helper for interfaces #237

Closed
ghostdogpr opened this issue Feb 23, 2020 · 0 comments · Fixed by #1169
Closed

Caliban client: better helper for interfaces #237

ghostdogpr opened this issue Feb 23, 2020 · 0 comments · Fixed by #1169
Labels
client GraphQL Client module enhancement New feature or request

Comments

@ghostdogpr
Copy link
Owner

ghostdogpr commented Feb 23, 2020 •
edited
Loading

Currently for each field that returns an interface, we generate a function that takes an optional SelectionBuilder for each type that implements the interface. If we want to select fields from the interface (common to all types), we still need to provide a SelectionBuilder for each type.

We need something more user-friendly for that particular use case.
@ghostdogpr ghostdogpr added enhancement New feature or request client GraphQL Client module labels Feb 23, 2020
@ghostdogpr ghostdogpr mentioned this issue Oct 21, 2021
Merged
@AlixBa AlixBa mentioned this issue Nov 24, 2021
Merged
ghostdogpr pushed a commit that referenced this issue Nov 25, 2021
@AlixBa
feat(client): provide a way to select interfaces fields (#1169)
9efd71b 
closes #237
Fluxx pushed a commit to Fluxx/caliban that referenced this issue Jan 24, 2022
@AlixBa @Fluxx
feat(client): provide a way to select interfaces fields (ghostdogpr#1169
c92528a 
)

closes ghostdogpr#237
Fluxx pushed a commit to Fluxx/caliban that referenced this issue Jan 27, 2022
@AlixBa @Fluxx
feat(client): provide a way to select interfaces fields (ghostdogpr#1169
7cd39c6 
)

closes ghostdogpr#237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client GraphQL Client module enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(client): provide a way to select interfaces fields AlixBa/caliban
1 participant
@ghostdogpr