Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema validation: unions #230

Closed
ghostdogpr opened this issue Feb 22, 2020 · 1 comment · Fixed by #233
Closed

Schema validation: unions #230

ghostdogpr opened this issue Feb 22, 2020 · 1 comment · Fixed by #233
Labels
good first issue Good for newcomers server Issue related to caliban server

Comments

@ghostdogpr
Copy link
Owner

ghostdogpr commented Feb 22, 2020

In Validator.validateSchema, verify the rules for union types

  1. A Union type must include one or more unique member types.
  2. The member types of a Union type must all be Object base types;
    Scalar, Interface and Union types must not be member types of a Union.
    Similarly, wrapping types must not be member types of a Union.
@palanga
Copy link
Contributor

palanga commented Feb 22, 2020

Can I take this ?

palanga added a commit to palanga/caliban that referenced this issue Feb 22, 2020
palanga added a commit to palanga/caliban that referenced this issue Feb 23, 2020
ghostdogpr pushed a commit that referenced this issue Feb 23, 2020
@ghostdogpr ghostdogpr added server Issue related to caliban server core labels Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers server Issue related to caliban server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants