Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module for apollo-tracing support #133

Closed
ghostdogpr opened this issue Dec 20, 2019 · 1 comment · Fixed by #165
Closed

Add module for apollo-tracing support #133

ghostdogpr opened this issue Dec 20, 2019 · 1 comment · Fixed by #165
Labels
enhancement New feature or request

Comments

@ghostdogpr
Copy link
Owner

See specs here: https://github.com/apollographql/apollo-tracing
@ghostdogpr ghostdogpr added enhancement New feature or request help wanted labels Dec 20, 2019
@ghostdogpr
Copy link
Owner Author

The following features are necessary:

  • collect information during execution:
    • overall: startTime, endTime, duration
    • parsing: startOffset, duration
    • validation: startOffset, duration
    • execution: for each field: path, parentType, returnType, startOffset, duration
  • add (optionally) collected information into an "extensions" field in the response

Ideas:

  • overall info can be collected with wrapExecutionWith (add timers + inject result into ZIO env)
  • parsing/validation info collection is not supported, need to think about it
  • field info collection is not supported but will be with Ability to wrap field execution #99

ghostdogpr added a commit that referenced this issue Jan 12, 2020
@ghostdogpr
Fixes #99 #133 #157
6fa249b
@ghostdogpr ghostdogpr mentioned this issue Jan 13, 2020
Merged
ghostdogpr added a commit that referenced this issue Jan 17, 2020
@ghostdogpr
Wrappers + Apollo Tracing (#165)
b461fb1 
* Fixes #99 #133 #157

* Cleanup

* Add comment

* Fix parentType and returnType

* Add scaladoc and tests

* Add documentation

* Apply review fixes

* Apply review comments

* Replace query analyzers by the new wrapper feature

* Update docs

* Simplify code

* Simplify further
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrappers + Apollo Tracing ghostdogpr/caliban
1 participant
@ghostdogpr