Weather effects not working within area of light sources #149
Comments
|
Thanks for the report. I was not able to reproduce this locally, it seems to be working just fine: I tried this with all the modules you listed activated. Are you using any other modules? What lighting settings are you using? Could you export the problematic scene and send it to me, so I can try it with that? |
|
HI, thanks for picking this up! Here's my full module list and the scene, as well as a screenshot of the lighting settings: Active Modules:5e-Sheet Resources Plus v1.6.11; Inactive Modules:Adventure Importer / Exporter v0.7.1; |
|
Thanks for the detailed list and the exported scene! Let's see if I can reproduce it with that :) |
|
I'm also running into this issue (notice the embers in the dark parts of the windmill interior - which isn't lit): I'd really like to add some rain / fog to this scene but, because I have the outside illuminated with lights, I'm unable to produce that effect. Let me know if there's anything I can do to help (happy to help dig into the code / console). |
You could try deactivating all other modules and see if the issue persists. If it doesn't, you could use the find the culprit module to figure out which of the modules causes the conflict. |
|
@ghost91- I just went through and disabled each module individually (list below - I don't use too many) and was unable to get this working right. I then disabled all of the modules except FXMaster and I am still seeing this issue. Just double-checked and I am on the latest version of the module.
|
|
@Aezrel some of those modules break your scene even without FXMaster. I would strongly recommend you to rethink some of the module choices. Most of them are not marked ready for V9. Some even haven't been updated since foundry 0.5... It's difficult to test it this way. With all the modules deactivated (except for FXMaster), things look fine on my end (the warning triangles are due to the missing assets):
|
|
@zstix Could you export your scene, and upload it as a zip, with all the required assets (background image, any tiles that are being used, etc.)? |
|
@Aezrel ok, after activating the modules one by one, it's now also working with all those modules on my side. I don't see what you are seeing... |
|
could you try and see what happens with regular weather effects from foundry core? I.e., deactivate FXMaster and set a weather effect in the Ambience tab of the scene configuration, e.g. the autumn leaves. DO those leaves appear in the light areas? |
|
Also, could you try a different browser? If you've been using Chrome, try Firefox, etc. This all seems really weird to me... oO |
|
Trying in firefox, I got the following error: Here's a JSON export of the scene I'm working with. I haven't exported a scene before, so let me know if you need anything else: |
|
That's also a weird error.... I'll have to look into that, too. With your scene, I am able to reproduce it now. And I figured out, what exactly causes it: If you change some of the settings in the Advanced Options of a light source, such as Luminosity, or Background Saturation, the particles vanish... I'll have to look deeper into how the new lighting system works in order to figure out how to avoid that... |
|
The core weather effects avoid this problem by simply putting the weather effect layer above the lighting layer. Doing the same for FXMaster "fixes" the issue but then weather effects are not affected by lighting / sight anymore. In particular, effects are visible in black fog of war areas. It's the same for the core weather effects but this really sucks... |
|
Looks like putting it into the primary group also works... |
This is done by moving both the fxmaster layer and the specials layer to the primary group. Closes #149
This is done by moving both the fxmaster layer and the specials layer to the primary group. Closes #149
|
@ghost91- Yaaas it's fixed!
I'm also no longer seeing that error in Firefox. Thank you so much for the quick turnaround time! I really appreciate it! |
|
@ghost91- @zstix Wow, you guys were hard at work! I updated the module to the latest version and it's fixed for me too! I know my mod list is a controversial topic but weirdly enough it's been working fine, actually xD; sorry it was extra work for you though, glad zstix was able to help. Thanks for the fix and for all your hard work! |
Expected Behavior
Weather effects such as clouds/embers/fog are not affected by lighting
Current Behavior
In the light source's area of effect, weather effects disappear. They continue moving across the map (you can see an effect entering the area of the light source, disappear and then come out the other side) but don't show up within the area of the light.
Steps to Reproduce
Context
Version
2.1.1
Foundry VTT Version
9.238
Operating System
Windows 10
Browser / App
Chrome
Game System
dnd5e
Relevant Modules
Sequencer, weatherblocker, dynamic illumination, lessfog
The text was updated successfully, but these errors were encountered: