Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add smsg service apis #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

potmarion
Copy link

There are some services for Ghost RPC apis. Smsg service is ready to use. Everyone can send, view, list, delete messages.

@gmkaddar
Copy link

This isn't done, or at least I don't understand how it works haha.

Some issues I found:
Require /services doesn’t work everything is in /lib
No error handling when RPC port is unavailable. Uncaught error.
Error handling on incorrect user details non existent, uncaught error.
Running index, prints blockchain info as expected but there's no express or API handling or routing or anything to make this do anything.

All the code seems to be in the lib folder, which has all the functions ready to go but the index doesn't setup express.

@potmarion
Copy link
Author

This is just a library, so every user can create their own express service and use these library functions. It's more efficient than making express functions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants