Modified default_pam_*_line to add vas #65
Conversation
|
@ghoneycutt - can you merge please? |
| file { 'pam_system_auth_ac': | ||
| ensure => file, | ||
| ensure => 'file', |
There was a problem hiding this comment.
ensure lines do not need quotes for values of file, directory, link, present, absent, etc.
|
Commit message is misleading. There are changes to Solaris 9, 10, and 11 in here. This makes it really difficult to merge as you have 1,136 additions and 458 deletions. Sending a PR that is small in focus so that you are only changing the smallest amount possible in order to get real benefit such as changing VAS values or supporting one new platform make it easy for the upstream developer to understand your change, see that it works, and has appropriate tests. This commit is just too big and ambitious to fully grok. Suggest using git-rebase and breaking into smaller chunks that are manageable. |
|
Hi Garrett, Just break it only to change for Solaris 10. Here is the new PR #78 |
ghost
closed this
changed default_pam_{auth,account,password,session}_lines for Solaris to add VAS