BREAKING CHANGE: merge SlickGrid into Slickgrid-Universal & drop external dep #1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(core)!: use new SlickGrid ESM version (#1070) * feat(core)!: move SlickGrid core files directly into the project - drop `slickgrid` npm dependency and instead move all files into the project - the end goal is to have less depencies but also to get rid of unused code like the SlickGrid AutoSize since we have our own code in our ResizerService, this will hopefully make the build smaller as well. There are other duplicate code elsewhere, so moving the code in the project should help simplify the code
#1195) * chore(binding): move BindingEventService to from commom to binding pkg
* chore: remove leftover jQuery animations in all toggle methods
* chore: remove more autosize unused code * chore: add index barrel to Jest coverage ignore
- also remove unused old multiple-select image for dropdown icons
* chore: add full test coverage on slick.core utils
…er (#1206) * chore: remove unused slickCore exports & cleanup slick namespace leftover
- it's being showing as deprecated for a few years on MDN, they suggest to use `key` instead which is what we'll do
- fixes an issue when trying to publish ms-select-vanilla lib with npm provenance, I found that it was missing some SASS files even though it was working fine locally, it turns out that as pointed out in the `copyfiles` lib, we are better off escaping copyfiles glob patterns in npm scripts > if your terminal doesn't support globstars then you can quote them
* fix: changing `enableCellNavigation` grid option not working - the previous code had 2 different `options` and `_options` that were not always in sync which caused issue when trying to update for example the `enableCellNavigation` option on the fly. With this new code change, there will no possibility to mix them up anywmore
…#1263) * chore: move all DOM utilities to `@slickgrid-universal/utils` package
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1264 +/- ##
============================================
- Coverage 100.00% 86.71% -13.29%
============================================
Files 246 197 -49
Lines 17321 21370 +4049
Branches 6261 7099 +838
============================================
+ Hits 17321 18528 +1207
- Misses 0 2842 +2842 ☔ View full report in Codecov by Sentry. |
ghiscoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6pac/slickgriddependency and is instead merging the SlickGrid directly into Slickgrid-Universal code. This is now possible because the original SlickGrid got migrated to TypeScript couple months ago and we can now simply copy over this code in here, it was also tested in the wild for a while now so it's quite stable and all new reported bugs were fixed.innerHTMLuse & returnTrustedHTMLwhen used, also accept Formatter returning native HTML element which could improve perf & is 100% CSP safe because it's already native)6pac/SlickGridnever had any unit tests, so merging the code in here will obviously decrease the coverage. The coverage will be addressed in the coming months