Incorrect handling of BaseDN in search.js #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the network.js tests to use chai assertions. It also fixes a bug wherein the callback was not being invoked on error during authentication.
This commit adds a mock LDAP server that emulates some Active Directory functionality -- non-conforming usernames. The authenticate.js tests were updated to use this mock server and the chai assertion library.
This commit updates the getGroupMembershipForUser tests. It also fixes a bug wherein the documented default attributes for a group query were not reflected in the code.
This commit updates the getUsersForGroup tests. It also fixes a bug wherein the documented default user attributes were not being returned correctly.
This commit fixes a bug in #findGroups() wherein it was "picking" the default attributes for users, not groups.
This commit adds support for returning the correct error type when the AnInvalidUsername test is invoked. Previously, it was a crapshoot as to when the test would pass. And if it didn't pass then random other tests would fail.
This commit attempts to clarify the mockServer implementation with some more comments. It also cleans up a couple items such as unused variables and dead code/comments.
This commit merges in upstream master to remedy merge conflicts.
This commit refactors the "Range Retrieval Specifier Attribute" class. The name has been shortened to "RangeAttribute" and most of the methods have been converted to static methods. Additionally, the dependence on the underscore library was removed. Tests are included to verify all functionality.
Merge `next` branch into main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If baseDN is set to '' (empty string) in opts to start the search at the root, ad.baseDN value will be used instead of preset baseDN.baseDN in search.js in line 329
options.baseDN = baseDN.baseDN || ad.baseDNIt should be:
options.baseDN = (baseDN.baseDN === void 0) ? ad.baseDN : baseDN.baseDN