Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aeson upper bound to 1.1 #71

Closed
wants to merge 1 commit into from
Closed

Bump aeson upper bound to 1.1 #71

wants to merge 1 commit into from

Conversation

spl
Copy link

@spl spl commented Oct 19, 2016

No description provided.

@spl
Copy link
Author

spl commented Oct 19, 2016

Does this change require changing shims? I'm now seeing this error in my app, and I think it's related to using aeson-1.0.2.0.

uncaught exception in Haskell thread: ReferenceError: h$_js_decode_string is not defined
all.js:7069 ReferenceError: h$_js_decode_string is not defined
    at h$$kyZ (all.js:535090)
    at h$runThreadSlice (all.js:8018)
    at h$runThreadSliceCatch (all.js:7968)
    at h$mainLoop (all.js:7963)
    at all.js:8506
    at XMLHttpRequest.load (all.js:23707)

Related: haskell/aeson#471

@tolysz
Copy link

tolysz commented Oct 19, 2016

My best guess is to have pure Haskell version for this module, and if it is slower and working it is much better then faster and broken. The choice which module to build should be done in .cabal

@alexanderkjeldaas
Copy link

Any solution to this?

@tolysz
Copy link

tolysz commented Nov 5, 2016

The whole module is a simple function for decoding strings, UTF8->UCS2 please write it in Haskell, or "borrow" from some plethora libraries which does it but are not as performing as the C(state machine) version

@hamishmack
Copy link
Member

Closing this as I think this is out of date now. The upper bound is currently 1.2 and my understanding is that aeson-1.1.1.0 includes ghcjs support.

@hamishmack hamishmack closed this Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants