Fix to add PVC Metadata to VolumeLabels (libopenstorage#1208)

Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths · Aug 29, 2019 · 7a16091 · 7a16091
1 parent 1241c73
commit 7a16091
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/csi/controller.go b/csi/controller.go
@@ -334,9 +334,12 @@ func (s *OsdCsiServer) CreateVolume(
 	// Get PVC Metadata and add to locator.VolumeLabels
 	pvcMetadata, err := getPVCMetadata(req.GetParameters())
 	if err != nil {
-		for k, v := range pvcMetadata {
-			locator.VolumeLabels[k] = v
-		}
+		return nil, status.Errorf(
+			codes.Internal,
+			"Unable to get PVC Metadata: %v", err)
+	}
+	for k, v := range pvcMetadata {
+		locator.VolumeLabels[k] = v
 	}
 
 	// Get parent ID from request: snapshot or volume