Fix edge case of extracting a 0 byte sized file

ggnkua · Sep 13, 2023 · 8b8ca47 · 8b8ca47
1 parent 01f838a
commit 8b8ca47
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 7 deletions.
diff --git a/dllmain.c b/dllmain.c
@@ -1182,10 +1182,14 @@ int Process(tArchive* hArcData, int Operation, char* DestPath, char* DestName)
 			free(buf);
 			return E_EWRITE;
 		}
-		size_t wlen = fwrite(buf, len, 1, f);
-		if (ProcessDataProc)
+		size_t wlen = 1;
+		if (len)
 		{
-			abort = !ProcessDataProc(DestName, len);
+			size_t wlen = fwrite(buf, len, 1, f);
+			if (ProcessDataProc)
+			{
+				abort = !ProcessDataProc(DestName, len);
+			}
 		}
 		if (wlen != 1 || abort) {
 			free(buf);

diff --git a/install/jacknife.wcx b/install/jacknife.wcx
diff --git a/install/jacknife.wcx64 b/install/jacknife.wcx64
diff --git a/install/jacknife.zip b/install/jacknife.zip
diff --git a/install/jacknife_ctrlpagedownonly.zip b/install/jacknife_ctrlpagedownonly.zip
diff --git a/install/readme.md b/install/readme.md
@@ -42,8 +42,11 @@ Progress bar info during operations                         |&check;|&check; |&c
 Pre-built binaries are supplied.
 
 ### Linux/OSX
-Starting with v0.05 pre-built binaries are supplied in the releases.
-To build manually, use the `build_linux_mac.sh` script to build the plugin and follow the instructions below for Double Commander.
+Starting with v0.05 pre-built binaries are supplied in the releases. To install, follow the instructions below for Double Commander.
+
+There is a possibility that on OSX a message like "Cannot Be Opened Because the Developer Cannot be Verified". If that happens, the only course of action is to implicitly "trust the developer". Several guides exist on the internet about how to achieve this.
+
+To build manually, use the `build_linux_mac.sh` script to build the plugin. Then see the Double Commander section below on how to install the plugin.
 
 ### Total Commander
 

diff --git a/readme.md b/readme.md
@@ -42,8 +42,11 @@ Progress bar info during operations                         |&check;|&check; |&c
 Pre-built binaries are supplied.
 
 ### Linux/OSX
-Starting with v0.05 pre-built binaries are supplied in the releases.
-To build manually, use the `build_linux_mac.sh` script to build the plugin and follow the instructions below for Double Commander.
+Starting with v0.05 pre-built binaries are supplied in the releases. To install, follow the instructions below for Double Commander.
+
+There is a possibility that on OSX a message like "Cannot Be Opened Because the Developer Cannot be Verified". If that happens, the only course of action is to implicitly "trust the developer". Several guides exist on the internet about how to achieve this.
+
+To build manually, use the `build_linux_mac.sh` script to build the plugin. Then see the Double Commander section below on how to install the plugin.
 
 ### Total Commander